ASHP and summary endpoint updates #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying SSL issue appears to be tied to libgit2 library being unable to read a PEM file format, and hence errors. Workaround is to use
Fix a few bugs and cover a gap in re-linking portfolios and runs.
Updated JSON response to delineate between adding a portfolio uuid vs deleting from existing portfolio runs.
Bug fix and cover a gap
Add I/O for ElectricHeater, ASHPWaterHeater, and ASHPSpaceHeater
Bill-Becker
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
See #590, #600, #601
What is the current behavior?
(You can also link to an open issue here)
See #590, #600, #601
What is the new behavior (if this is a feature change)?
See #590, #600, #601
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
No
Other information:
Also change how REopt is instantiated in julia_src -> Dockerfile to move away from
libgit2